Add merge/unmerge loads feature. #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IIDM files used in tests have been updated as well. Signed-off-by: BAUDRIER Dimitri <dimitri.baudrier@rte-france.com>
There's a control on the network ID. A DynawoResultsMergeLoads is associated to a unique network via its ID. Signed-off-by: BAUDRIER Dimitri <dimitri.baudrier@rte-france.com>
By default, the property mergeLoads is true. Signed-off-by: BAUDRIER Dimitri <dimitri.baudrier@rte-france.com>
dimbdr
force-pushed
the
merge-loads
branch
3 times, most recently
from
d5c8c8f to
167abde
Compare
dimbdr
force-pushed
the
merge-loads
branch
2 times, most recently
from
27a5773 to
d75b991
Compare
Updated test resources, to compare results when the property mergeLoads is true Signed-off-by: BAUDRIER Dimitri <dimitri.baudrier@rte-france.com>
Signed-off-by: BAUDRIER Dimitri <dimitri.baudrier@rte-france.com>
dimbdr
commented
Nov 24, 2022
| @@ -177,6 +218,28 @@ public void testUpdate() throws Exception { | |||
| compare(expectedNetwork, network); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testUpdateWithMergeLoads() throws Exception { | |||
There was a problem hiding this comment.
I'm wondering.
I created this test, but is it really necessary to compare the network unmerged with the resource SmallBusBranch_outputIIDM.xml?
Since there are tests associated to the methods merge/unmerge (DynawoResultsMergeLoadsTest), and they are supposed to guarantee it works, then it should not be necessary to reconfirm the unmerge is successful when reading the network transformed into a xiidm file. I might be wrong.
Signed-off-by: BAUDRIER Dimitri <dimitri.baudrier@rte-france.com>
flo-dup
force-pushed
the
merge-loads
branch
6 times, most recently
from
ce77215 to
2db79ce
Compare
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
|
Kudos, SonarCloud Quality Gate passed! |
flo-dup
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restfixes #122
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Proposal on how to merge/unmerge bunch of loads on a same bus in a network.